Skip to content

[NDTensors] Introduce LabelledNumbers and GradedAxesNext#1351

Merged
mtfishman merged 8 commits into
mainfrom
GradedAxesNext
Mar 15, 2024
Merged

[NDTensors] Introduce LabelledNumbers and GradedAxesNext#1351
mtfishman merged 8 commits into
mainfrom
GradedAxesNext

Conversation

@mtfishman

@mtfishman mtfishman commented Mar 12, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

This is a rewrite and redesign of GradedAxes, for now called GradedAxesNext but the goal will be to remove GradedAxes and replace it with the code in GradedAxesNext (either here or in a follow-up PR). The goal is to make it easier to implement slicing operations of graded unit ranges which preserve the sector labels (which is needed for finishing #1332), which I have found is a bit more cumbersome than I think is necessary with the current GradedAxes design.

@emstoudenmire @ogauthe

@codecov-commenter

codecov-commenter commented Mar 12, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.78%. Comparing base (638624f) to head (887f612).

❗ Current head 887f612 differs from pull request most recent head 97cbccd. Consider uploading reports for the commit 97cbccd to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #1351       +/-   ##
===========================================
- Coverage   84.40%   53.78%   -30.62%     
===========================================
  Files         100       99        -1     
  Lines        8581     8528       -53     
===========================================
- Hits         7243     4587     -2656     
- Misses       1338     3941     +2603

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtfishman mtfishman changed the title [NDTensors] Introduce LabelledNumbers and GradedAxesNext [WIP][NDTensors] Introduce LabelledNumbers and GradedAxesNext Mar 13, 2024
@mtfishman mtfishman marked this pull request as ready for review March 14, 2024 21:45
@mtfishman

mtfishman commented Mar 14, 2024 •
edited
Loading

Copy link
Copy Markdown
Member Author

@ogauthe this doesn't have all of the features of GradedAxes, but it has a lot more support for slicing (see the tests). I will merge this as-is and we can start adding more features to it, like fusion, and plan to get ride of GradedAxes as soon as possible.

@mtfishman mtfishman changed the title [WIP][NDTensors] Introduce LabelledNumbers and GradedAxesNext [NDTensors] Introduce LabelledNumbers and GradedAxesNext Mar 14, 2024
@ogauthe

ogauthe commented Mar 14, 2024

Copy link
Copy Markdown
Contributor

Great. I paused my work on GradedAxes to wait for your updates.

@mtfishman mtfishman merged commit 12fbcc2 into main Mar 15, 2024
@mtfishman mtfishman deleted the GradedAxesNext branch March 15, 2024 00:16
@mtfishman mtfishman mentioned this pull request Mar 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mtfishman @codecov-commenter @ogauthe